Uh oh!
There was an error while loading. Please reload this page.
add(hook): content:manifest - #3734
Conversation
@hareland is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds a new Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/content/docs/8.advanced/5.hooks.md`:
- Around line 46-49: The docs example incorrectly shows pushing
defineCollection() into manifest.collections; manifest.collections expects
ResolvedCollection, not the un-resolved collection builder. Update the snippet
around the 'content:manifest' hook to push a ResolvedCollection (for example the
object returned by resolveCollection or the result of calling the resolver you
use) or make the example generic (e.g., show pushing a variable typed as
ResolvedCollection) so that manifest.collections receives the correct
ResolvedCollection shape; reference the manifest.collections property and the
defineCollection() usage to locate and correct the example.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/module.ts`:
- Line 123: The call to nuxt.callHook('content:manifest', manifest) is not
awaited, so async hook handlers (which can return Promise<void>) may not
complete before subsequent code runs; update the call site in module.ts to await
the hook invocation (i.e., use await nuxt.callHook('content:manifest',
manifest)) and ensure the surrounding function is marked async if needed so
manifest mutations from registered handlers complete before proceeding.
Uh oh!
There was an error while loading. Please reload this page.
Would be nice to have a util like in nuxt |
❓ Type of change
📚 Description
Adds a hook for other modules to hook into the manifest generation, since this module only register other layers automatically.
This allows modules to hook into the generation process and add/modify it.
📝 Checklist