Uh oh!
There was an error while loading. Please reload this page.
fix(cache): await development cache replacement - #3846
Conversation
@onmax is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthrough
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk:⚪ Minimal · up to Development-cache replacement now completes deletion before writing replacement rows, preventing stale deletion from removing newly written cache data. The updated asynchronous contract and cache behavior are covered without an identified remaining merge risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c96b98b to
57c8150Compare57c8150 to
bd33b5fCompare
🔗 Linked issue
No linked issue.
❓ Type of change
📚 Description
Await development-cache deletion before inserting replacement rows, and await callers before initialization or HMR continues. Async db0 connectors could otherwise execute the delete after the insert, leaving a cold cache on the next startup; the HMR caller also stored its value and checksum in reverse order.
📝 Checklist