Uh oh!
There was an error while loading. Please reload this page.
fix(devtools): drop stale visibility assertion from nuxt-group e2e test - #1042
Conversation
feat(devtools)!: make embedded dock the only client mode (#1041) disabled the nuxt:devtools anchor's `visibility: 'false'` (its render-only hiding breaks the Nuxt group button's defaultChildId fallback) but left the e2e test asserting the old value, failing e2e on every push to main since.
Deploying nuxt-devtools with |
| Latest commit: | 8957945 |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://93137835.nuxt-devtools.pages.dev |
| Branch Preview URL: | https://purple-areas-win.nuxt-devtools.pages.dev |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Nuxt devtools E2E test updates its handling of the Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
Summary
e2ehas been failing on every push tomainsince #1041. That PR disabledthe
nuxt:devtoolsanchor's render-onlyvisibility: 'false'(it broke theNuxtgroup button'sdefaultChildIdfallback, which looks the anchor upthrough the same visibility filter), but left
nuxt-group.spec.tsassertingthe old
visibility: 'false'value in the same commit — so every e2e runacross all four playgrounds failed on that assertion.
This drops the stale assertion and expands the comment to explain why
visibility: 'false'is currently disabled inmodule-main.tsand whatneeds to happen upstream before it (and this assertion) can be restored.
Verification
pnpm buildPW_PROJECT='*:dev' pnpm test:e2e:dev --grep nuxt-group— passes acrossempty,spa,tab-pinia,tab-seo🤖 Generated with the help of an agent.