Uh oh!
There was an error while loading. Please reload this page.
feat!: remove @vue/devtools integration - #1056
Merged
Merged
Conversation
Vue DevTools is being refactored onto Vite DevTools too, so it can be added as a lightweight, independent plugin rather than bundled and rebundled inside Nuxt DevTools. Removes the Pinia and Render Tree tabs (both @vue/devtools-applet embeds), their RPC bridge (@vue/devtools-core/@vue/devtools-kit), the vueDevTools module option, and the tab-pinia playground/e2e spec that only existed to exercise those tabs. Cleans up the now-unused @vue/devtools* and tab-pinia-only (cypress/pinia/@exampledev) catalog entries. Co-authored-by: opencode <noreply@opencode.ai>
Deploying nuxt-devtools with |
| Latest commit: | 55cbcd0 |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7e5de0fc.nuxt-devtools.pages.dev |
| Branch Preview URL: | https://chore-remove-vue-devtools-in.nuxt-devtools.pages.dev |
Contributor
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (32)
💤 Files with no reviewable changes (28)
📝 WalkthroughWalkthroughThe change removes Vue DevTools integration, categories, dependencies, iframe binding, and related configuration. It removes the Pinia playground and its E2E coverage. Workspace catalogs no longer include Vue DevTools, Pinia, the playground catalog, or Cypress entries. Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vue DevTools is being refactored onto Vite DevTools too, so it can be added as a lightweight, independent plugin instead of being bundled (and rebuilt) inside Nuxt DevTools. This removes that integration and its dependency footprint, making Nuxt DevTools quite a lot thinner.
Removed:
@vue/devtools-appletcomponents) and their shared client-side RPC bootstrapvue-devtoolsintegration that injected the@vue/devtools-kitRPC server plugin, and the iframe-binding glue that fed its messaging channelvueDevToolsmodule option and thevue-devtoolstab categorytab-piniaplayground and its e2e spec, which existed solely to exercise the now-removed Pinia tab@vue/devtools-core,@vue/devtools-kit,@vue/devtools-appletdependencies and their catalog entries, plus thecypress/pinia/@pinia/nuxt/@exampledev/new.csscatalog entries that were only used by the deleted playgroundVerified
pnpm lint,pnpm typecheck,pnpm knip, andpnpm test:unitall pass (knip findings are a strict subset of what a clean checkout ofmainalready reports).This PR was created with the help of an agent.