Skip to content

fix: resolve devtools client runtime errors - #1075

Merged
antfu merged 1 commit into
mainfrom
codex/fix-devtools-runtime-errors
Aug 21, 2026
Merged

fix: resolve devtools client runtime errors#1075
antfu merged 1 commit into
mainfrom
codex/fix-devtools-runtime-errors

Conversation

@antfu

Copy link
Copy Markdown
Member

Summary

  • generate a browser-safe development stub for the webcomponents entry instead of loading it through Jiti
  • mount the Nuxt page/layout tree during connection, add the root redirect, and reuse the cached Nuxt version state
  • enable Vue Options API support required by floating-vue
  • drive host controls through the visible Devframe context and complete the real e2e trust handshake
  • add browser regression coverage for the reported console diagnostics and component dropdown rendering

Testing

  • pnpm lint
  • pnpm typecheck
  • pnpm test:unit (67 tests)
  • focused Playwright runtime-console and Components-tab tests (2 passed)
  • pnpm -C packages/devtools build:client
  • pnpm -C packages/devtools dev:prepare

@antfu
antfu merged commit 7dac16d into mainAug 21, 2026
3 of 6 checks passed
@antfu
antfu deleted the codex/fix-devtools-runtime-errors branch August 21, 2026 23:15
@coderabbitai

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 11f780d7-70c9-4d16-a0af-4286320cc6aa

📥 Commits

Reviewing files that changed from the base of the PR and between 30541d9 and 3bede91.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (11)
  • packages/devtools/build.config.ts
  • packages/devtools/client/app.vue
  • packages/devtools/client/composables/npm.ts
  • packages/devtools/client/nuxt.config.ts
  • packages/devtools/client/pages/index.vue
  • packages/devtools/package.json
  • packages/devtools/src/runtime/plugins/view/client.ts
  • pnpm-workspace.yaml
  • tests/e2e/fixtures/devtools.ts
  • tests/e2e/specs/runtime-console.spec.ts
  • tests/e2e/specs/tabs.spec.ts

📝 Walkthrough

Walkthrough

The DevTools build now generates a web-components stub for stub builds. Runtime view controls now use Devframe context, panel sessions, and a shared Nuxt dock anchor. The client shell supports Vue Options API dependencies, shared Nuxt package-update state, persistent mounting, and index-page redirection. E2E setup now completes the Devframe trust handshake, with added component and runtime diagnostic checks.

Estimated code review effort: 3 (Moderate) | ~20 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-devtools-runtime-errors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@antfu