Skip to content

fix(ui-kit): dedupe mkdist so dist ships .vue SFCs - #1076

Closed
danielroe wants to merge 1 commit into
v3from
fix/ui-kit-vue-files
Closed

fix(ui-kit): dedupe mkdist so dist ships .vue SFCs#1076
danielroe wants to merge 1 commit into
v3from
fix/ui-kit-vue-files

Conversation

@danielroe

@danielroedanielroe commented Aug 22, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

same issue as nuxt/module-builder#786

currently @nuxt/devtools-ui-kit v3 is broken

@danielroe
danielroe requested a review from antfuAugust 22, 2026 09:51
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying nuxt-devtools with Cloudflare Pages Cloudflare Pages

Latest commit:4fd4057
Status: ✅ Deploy successful!
Preview URL:https://f759e5f2.nuxt-devtools.pages.dev
Branch Preview URL:https://fix-ui-kit-vue-files.nuxt-devtools.pages.dev

View logs

@danielroe
danielroe marked this pull request as ready for review August 22, 2026 09:53
@coderabbitai

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e0c3fb30-62fe-4625-b53a-7f8315ee7545

📥 Commits

Reviewing files that changed from the base of the PR and between 39a6dbb and 4fd4057.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The workspace adds mkdist version ^2.4.1 to the buildtools catalog. The workspace overrides map mkdist to that catalog entry.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to 4fd40

This localized dependency and workspace configuration change has no actionable merge-blocking risk remaining and is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly states that the change deduplicates mkdist to ensure .vue SFCs ship in the distribution.
Description check✅ PassedThe description identifies the broken @nuxt/devtools-ui-kit v3 issue and links it to the related mkdist problem.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ui-kit-vue-files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@danielroe