Skip to content

fix(ui-kit): dedupe mkdist so dist ships .vue SFCs - #1078

Merged
antfu merged 1 commit into
v3from
fix/ui-kit-vue-files
Aug 22, 2026
Merged

fix(ui-kit): dedupe mkdist so dist ships .vue SFCs#1078
antfu merged 1 commit into
v3from
fix/ui-kit-vue-files

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

same issue as nuxt/module-builder#786

currently @nuxt/devtools-ui-kit v3 is broken

@danielroe
danielroe requested a review from antfuAugust 22, 2026 11:20
@danielroe
danielroe marked this pull request as ready for review August 22, 2026 11:20
@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6916173a-346c-49e9-97f1-fd062c8d1afb

📥 Commits

Reviewing files that changed from the base of the PR and between fdd8d41 and cc4c6f2.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The workspace configuration adds mkdist version ^2.4.1 to the buildtools catalog. The workspace override map resolves mkdist through that catalog entry.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to cc4c6

This change updates workspace and lockfile configuration to support shipping Vue SFCs; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Title check✅ PassedThe title clearly describes deduplicating mkdist to ensure the distribution ships .vue SFCs.
Description check✅ PassedThe description identifies the related module-builder issue and explains that @nuxt/devtools-ui-kit v3 is broken.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ui-kit-vue-files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying nuxt-devtools with Cloudflare Pages Cloudflare Pages

Latest commit:cc4c6f2
Status: ✅ Deploy successful!
Preview URL:https://a7567f9f.nuxt-devtools.pages.dev
Branch Preview URL:https://fix-ui-kit-vue-files.nuxt-devtools.pages.dev

View logs

Base automatically changed from fix/unhead-v3 to v3August 22, 2026 22:47
@antfu
antfuforce-pushed the fix/ui-kit-vue-files branch from cc4c6f2 to c6ec13eCompareAugust 22, 2026 22:47
@antfu
antfu merged commit 48a93c7 into v3Aug 22, 2026
2 of 3 checks passed
@antfu
antfu deleted the fix/ui-kit-vue-files branch August 22, 2026 22:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@antfu