Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat: composables import path - #10084

Closed
ineshbose wants to merge 3 commits into
nuxt:mainfrom
ineshbose:patch-1
Closed

feat: composables import path#10084
ineshbose wants to merge 3 commits into
nuxt:mainfrom
ineshbose:patch-1

Conversation

@ineshbose

Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/nuxt#12414

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added 'composables/*/index.{ts,js,mjs,mts}' to composable imports to scan the same way as plugins/

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@ineshboseineshbose changed the title refactor: composables import pathfeat: composables import pathJan 13, 2023
Comment threadpackages/nuxt/src/imports/module.ts
@danielroe

Copy link
Copy Markdown
Member

Here's some context: #6025.

@ineshbose

ineshbose commented Jan 13, 2023

Copy link
Copy Markdown
MemberAuthor

Thanks for linking the previous discussion(s). I see nuxt/nuxt#14358 open as well in that regard, so the planned approach instead is for plugins/ to only scan top level. Up to you to close this!

Edit: #10090 for plugins/

@danielroedanielroe added 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing 3.x enhancement New feature or request and removed enhancement New feature or request labels Jan 14, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ineshbose@danielroe