Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nitro): add nitro:build:before hook - #4304

Merged
pi0 merged 9 commits into
mainfrom
fix/nitro-generate-hook
May 2, 2022
Merged

feat(nitro): add nitro:build:before hook#4304
pi0 merged 9 commits into
mainfrom
fix/nitro-generate-hook

Conversation

@danielroe

@danielroedanielroe commented Apr 12, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#13701

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adds back nitro:generate hook.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working nitro ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Apr 12, 2022
@danielroe
danielroe requested a review from pi0April 12, 2022 15:27
@danielroedanielroe self-assigned this Apr 12, 2022
@netlify

netlifyBot commented Apr 12, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit23898bf
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62703b7a4a4eb70008732602

@danielroedanielroe mentioned this pull request Apr 13, 2022
Closed
@benoitdemaegdtbenoitdemaegdt mentioned this pull request Apr 14, 2022
Closed
@pi0

pi0 commented Apr 15, 2022

Copy link
Copy Markdown
Member

(PR is pending in order to deprecate nitro: hooks)

@pi0pi0 self-assigned this Apr 15, 2022
@pi0pi0 added the pending label Apr 15, 2022
@benoitdemaegdt

benoitdemaegdt commented Apr 19, 2022

Copy link
Copy Markdown

It seems that partytown module was fixed without the need of this PR :
nuxt-modules/partytown@bf4cfca

Will this PR be merged ? Or the intent is to close it ?

@pi0pi0 closed this Apr 19, 2022
@pi0
pi0 deleted the fix/nitro-generate-hook branch April 19, 2022 19:15
@danielroedanielroe mentioned this pull request Jan 19, 2023
Closed
@danielroe
danielroe restored the fix/nitro-generate-hook branch May 1, 2022 07:59
@danielroedanielroe reopened this May 1, 2022
pi0
pi0 reviewed May 2, 2022
View reviewed changes
Comment threadpackages/nuxt/src/core/nitro.ts
@pi0pi0 changed the title fix(nitro): add back nitro:generate hookfeat(nitro): add nitro:build:before hookMay 2, 2022
@pi0
pi0 merged commit 1f8e3e2 into mainMay 2, 2022
@pi0
pi0 deleted the fix/nitro-generate-hook branch May 2, 2022 20:15
@pi0pi0 mentioned this pull request May 2, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@pi0pi0

@danielroedanielroe

Labels

3.xbugSomething isn't workingnitro❗ p4-importantPriority 4: bugs that violate documented behavior, or significantly impact perfpending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add back nitro:generate hook

3 participants

@danielroe@pi0@benoitdemaegdt