Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxt3): allow separating client and server components - #4390

Merged
pi0 merged 8 commits into
mainfrom
feat/client-and-server-components
Apr 19, 2022
Merged

feat(nuxt3): allow separating client and server components#4390
pi0 merged 8 commits into
mainfrom
feat/client-and-server-components

Conversation

@danielroe

@danielroedanielroe commented Apr 15, 2022•
edited
Loading

Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/nuxt#11884, follow up on #1919

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR largely takes @antfu's code but slightly simplifies the scanning/loading implementation. There may be oversights - review welcome!

📝 Checklist

  • I have linked an issue or discussion.
  • update #build/components import to work in client/server mode
  • consider component name ending with Server/Client for clarity in Dev tools, etc.
  • I have updated the documentation accordingly.

@danielroe@antfu
feat(nuxt3): allow separating client and server components
1164a7e
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
@danielroedanielroe added enhancement New feature or request nuxt3 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Apr 15, 2022
@danielroe
danielroe requested a review from pi0April 15, 2022 23:54
@danielroedanielroe self-assigned this Apr 15, 2022
@netlify

netlifyBot commented Apr 15, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit32a6dfe
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/625acd0da925540009496842

@danielroe
danielroe marked this pull request as ready for review April 16, 2022 07:08
@misaon

misaon commented Apr 16, 2022

Copy link
Copy Markdown
Contributor

Perfect ♥️

@danielroe
danielroe requested a review from antfuApril 16, 2022 20:13
pi0
pi0 approved these changes Apr 19, 2022
View reviewed changes
@pi0
pi0 merged commit b38dc09 into mainApr 19, 2022
@pi0
pi0 deleted the feat/client-and-server-components branch April 19, 2022 19:13
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@antfuantfuAwaiting requested review from antfu
1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xenhancementNew feature or requestnuxt3🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@misaon@pi0