Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt3)!: include route children in parent suspense - #4422

Merged
pi0 merged 1 commit into
mainfrom
fix/nested-route-suspense
Apr 19, 2022
Merged

fix(nuxt3)!: include route children in parent suspense#4422
pi0 merged 1 commit into
mainfrom
fix/nested-route-suspense

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This wraps the suspense for child routes into it's parent, which means page:finish is now accurate (it means all route components have been fully resolved). However, it's a breaking change in that the hook is now only called once, with the top-level route component.

👉 Migration

The page:start and page:finish hooks are now only called once, with the top-level route component rather than any nested route components.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working pages 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Apr 19, 2022
@danielroe
danielroe requested a review from pi0April 19, 2022 08:34
@danielroedanielroe self-assigned this Apr 19, 2022
@netlify

netlifyBot commented Apr 19, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitda7c528
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/625e742d3fa78b00089277f3

@pi0
pi0 merged commit 7a316c2 into mainApr 19, 2022
@pi0
pi0 deleted the fix/nested-route-suspense branch April 19, 2022 08:38
@pi0

pi0 commented Apr 19, 2022

Copy link
Copy Markdown
Member

@danielroe Would you mind updating breaking change tracker?

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagepages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0