Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat: allow disabling sourcemap generation - #4509

Merged
pi0 merged 6 commits into
mainfrom
perf/sourcemap-build
Apr 22, 2022
Merged

feat: allow disabling sourcemap generation#4509
pi0 merged 6 commits into
mainfrom
perf/sourcemap-build

Conversation

@danielroe

@danielroedanielroe commented Apr 21, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR disables sourcemap generation for our various transform plugins when building. (I would also be open to adding a build.sourceMap option that allows configuring sourcemap generation.)

I've seen one or two reports of memory issues when building, and have previously resolved this with turning off magic string sourcemaps. For context:

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Apr 21, 2022
@danielroe
danielroe requested review from antfu and pi0April 21, 2022 14:57
@danielroedanielroe self-assigned this Apr 21, 2022
@netlify

netlifyBot commented Apr 21, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit79b2733
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6262c86e5071ad0009fb013a

@pi0

pi0 commented Apr 22, 2022

Copy link
Copy Markdown
Member

Do you have any context of the source map memory leak issue? It can happen when enabling development too and we can't just mask the issue this is a nice feature for production build too.

Comment threadpackages/schema/src/config/build.ts Outdated
@pi0pi0 changed the title perf: disable sourcemap generation when buildingperf: allow disabling sourcemap generationApr 22, 2022
@pi0pi0 changed the title perf: allow disabling sourcemap generationfeat: allow disabling sourcemap generationApr 22, 2022
@pi0
pi0 merged commit 650d12f into mainApr 22, 2022
@pi0
pi0 deleted the perf/sourcemap-build branch April 22, 2022 15:35
@pi0pi0 mentioned this pull request May 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xenhancementNew feature or request🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressingpending

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0