Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): transform virtual templates - #4512

Merged
pi0 merged 1 commit into
mainfrom
fix/virtual-transform
Apr 22, 2022
Merged

fix(vite): transform virtual templates#4512
pi0 merged 1 commit into
mainfrom
fix/virtual-transform

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#11791, resolvesnuxt/nuxt#13214

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Starting the prefix with \0 seems to short-circuit the vite/rollup transform process, meaning future transform plugins weren't being run. This change means we can process virtual files in the same way we can the rest of source materials for the build.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Apr 21, 2022
@danielroe
danielroe requested a review from pi0April 21, 2022 20:00
@danielroedanielroe self-assigned this Apr 21, 2022
@netlify

netlifyBot commented Apr 21, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit561f99f
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6261b7d6fb737e00081ff473

pi0
pi0 approved these changes Apr 22, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagevite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import typescript files inside virtual templates/create typescript templates Can't add Vue files as templates with Vite

2 participants

@danielroe@pi0