Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxi): don't strip file extensions from dirs in tsconfig - #4595

Merged
pi0 merged 2 commits into
mainfrom
fix/only-strip-from-files
Apr 25, 2022
Merged

fix(nuxi): don't strip file extensions from dirs in tsconfig#4595
pi0 merged 2 commits into
mainfrom
fix/only-strip-from-files

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#13816

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Previously we were stripping anything extension-like from a path, which also covered directories like app.com. This PR strips file extensions only if it's not a directory.

When we bump minimum node version to 14.17 then we could also use throwIfNoEntry: false.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working cli 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Apr 25, 2022
@danielroe
danielroe requested a review from pi0April 25, 2022 14:19
@danielroedanielroe self-assigned this Apr 25, 2022
@netlify

netlifyBot commented Apr 25, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitae7ed09
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6266b6fe62bb7c00081d3e97

pi0
pi0 approved these changes Apr 25, 2022
@pi0
pi0 merged commit 2d202b5 into mainApr 25, 2022
@pi0
pi0 deleted the fix/only-strip-from-files branch April 25, 2022 17:07
@pi0pi0 mentioned this pull request May 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't workingcli🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The tsconfig generated by nuxi is not as expected

2 participants

@danielroe@pi0