Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): don't match across newlines - #4596

Merged
pi0 merged 1 commit into
mainfrom
fix/newline-assets
Apr 25, 2022
Merged

fix(vite): don't match across newlines#4596
pi0 merged 1 commit into
mainfrom
fix/newline-assets

Conversation

@danielroe

Copy link
Copy Markdown
Member

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

In diagnosing another issue, I hit an edge condition that this resolves.

@danielroedanielroe added bug Something isn't working vite 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Apr 25, 2022
@danielroe
danielroe requested a review from pi0April 25, 2022 14:57
@danielroedanielroe self-assigned this Apr 25, 2022
@netlify

netlifyBot commented Apr 25, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit28c23f9
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6266b6d12624ed0009b3894e

pi0
pi0 approved these changes Apr 25, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... However, at least showing an example to PR description could be nice this change is clueless.

@pi0
pi0 merged commit b8d2e64 into mainApr 25, 2022
@pi0
pi0 deleted the fix/newline-assets branch April 25, 2022 16:55
@pi0pi0 mentioned this pull request May 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagevite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0