Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
docs(concepts): change phrasing - #4601
Merged
Merged
Conversation
The previous phrasing was grammatically incorrect.
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
florian-lefebvre
left a comment
Contributor
There was a problem hiding this comment.
Shouldn't it be "which allowed you" instead?
sammce
commented
Apr 26, 2022
ContributorAuthor
My rationale for using 'allows' was because Vue 3 still offers the Options API. If Vue 3 completely deprecated the Options API I would definitely use 'allowed'. I view the explanation in the docs as an objective definition of what the Options API is, not was, hence the present tense. I suppose either would work though. |
danielroe
approved these changes
Apr 26, 2022
pi0
commented
Apr 26, 2022
Member
Thanks. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Changes the phrasing of a sentence on the 'Vue.js development' page in the 'concepts' section to be more grammatically correct.