Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs: fix some minor typos - #4603

Merged
pi0 merged 10 commits into
nuxt:mainfrom
dantownsend:doc-fixes
Apr 26, 2022
Merged

docs: fix some minor typos#4603
pi0 merged 10 commits into
nuxt:mainfrom
dantownsend:doc-fixes

Conversation

@dantownsend

@dantownsenddantownsend commented Apr 25, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

N/A

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

While going through the Nuxt 3 docs today I came across a few minor typos.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Apr 25, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitdc4966c
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6267c3f4c9df63000a63cff0
😎 Deploy Previewhttps://deploy-preview-4603--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

DamianGlowala
DamianGlowala suggested changes Apr 25, 2022
View reviewed changes
Comment threaddocs/content/2.guide/1.concepts/3.rendering.md Outdated
Comment threaddocs/content/2.guide/1.concepts/3.rendering.md Outdated
Comment threaddocs/content/2.guide/1.concepts/3.rendering.md Outdated
Comment threaddocs/content/2.guide/1.concepts/2.vuejs-development.md Outdated
Comment threaddocs/content/2.guide/1.concepts/2.vuejs-development.md Outdated
dantownsendand others added 5 commits April 26, 2022 06:48
@dantownsend@DamianGlowala
Update docs/content/2.guide/1.concepts/3.rendering.md
132c4f3
Co-authored-by: Damian <48835293+DamianGlowala@users.noreply.github.com>
@dantownsend@DamianGlowala
Update docs/content/2.guide/1.concepts/3.rendering.md
f0a4d0f
Co-authored-by: Damian <48835293+DamianGlowala@users.noreply.github.com>
@dantownsend@DamianGlowala
Update docs/content/2.guide/1.concepts/3.rendering.md
9150c88
Co-authored-by: Damian <48835293+DamianGlowala@users.noreply.github.com>
@dantownsend@DamianGlowala
Update docs/content/2.guide/1.concepts/2.vuejs-development.md
c94f8e7
Co-authored-by: Damian <48835293+DamianGlowala@users.noreply.github.com>
@dantownsend@DamianGlowala
Update docs/content/2.guide/1.concepts/2.vuejs-development.md
589816a
Co-authored-by: Damian <48835293+DamianGlowala@users.noreply.github.com>
@dantownsend

dantownsend commented Apr 26, 2022

Copy link
Copy Markdown
ContributorAuthor

@DamianGlowala Thanks for the suggestions 👍

danielroe
danielroe reviewed Apr 26, 2022
View reviewed changes

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment threaddocs/content/2.guide/1.concepts/2.vuejs-development.md Outdated
Comment threaddocs/content/2.guide/1.concepts/3.rendering.md Outdated
@pi0pi0 changed the title docs: Fix some minor typosdocs: fix some minor typosApr 26, 2022
pi0
pi0 reviewed Apr 26, 2022
View reviewed changes
Comment threaddocs/content/2.guide/1.concepts/3.rendering.md

### Cons

- **Performance**: The user has to wait for the browser to download, parse and run javascript files. Depending on the network for the download part and the user's device for the parsing and execution, this can take some time and impact your user's experience.

@pi0pi0Apr 26, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antfu Shouldn't case-police have caught this?

@pi0

pi0 commented Apr 26, 2022

Copy link
Copy Markdown
Member

Thanks all 💚

@pi0
pi0 merged commit e378985 into nuxt:mainApr 26, 2022
@pi0pi0 mentioned this pull request May 2, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@pi0pi0pi0 left review comments
@danielroedanielroedanielroe approved these changes
@DamianGlowalaDamianGlowalaDamianGlowala requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dantownsend@pi0@danielroe@DamianGlowala