Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): cleanup auto imports on regenerate - #4626

Merged
pi0 merged 2 commits into
mainfrom
fix/clear-auto-imports
Apr 26, 2022
Merged

fix(nuxt): cleanup auto imports on regenerate#4626
pi0 merged 2 commits into
mainfrom
fix/clear-auto-imports

Conversation

@antfu

Copy link
Copy Markdown
Member

🔗 Linked issue

Fixnuxt/nuxt#13528

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Apr 26, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commita44d1f5
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62681365b705db00083e15f8
😎 Deploy Previewhttps://deploy-preview-4626--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ctx.clearDynamicImports()
await ctx.modifyDynamicImports(async (imports) => {
// Modules extending
await nuxt.callHook('autoImports:extend', imports)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as components, we might call this hook last (after scanning) giving a chance to modules to apply their custom extending logic also including user project.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks for the notice!

@pi0pi0 changed the title fix: clearup auto imports on regeneratefix(nuxt): clearup auto imports on regenerateApr 26, 2022
@antfuantfu changed the title fix(nuxt): clearup auto imports on regeneratefix(nuxt): cleanup auto imports on regenerateApr 26, 2022
@pi0
pi0 merged commit eb4b8c4 into mainApr 26, 2022
@pi0
pi0 deleted the fix/clear-auto-imports branch April 26, 2022 15:52
@pi0pi0 mentioned this pull request May 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicated imports "definePageMeta" the one from "[app_root]/node_modules/nuxt3/dist/pages/runtime/composables" has been ignored.

3 participants

@antfu@pi0@danielroe