Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(compat): only move server.js if it has been regenerated - #463
Closed
farnabaz wants to merge 3 commits into
Closed
fix(compat): only move server.js if it has been regenerated#463farnabaz wants to merge 3 commits into
server.js if it has been regenerated#463farnabaz wants to merge 3 commits into
Conversation
atinux
commented
Aug 31, 2021
Member
I can confirm this error with latest Docus core + Nitro. |
danielroe
commented
Aug 31, 2021
Member
@atinux Do you have any steps for reproduction? |
atinux
commented
Aug 31, 2021
Member
|
atinux
commented
Aug 31, 2021
Member
Tahul
commented
Sep 1, 2021
Contributor
I can confirm applying the Ahad's suggested fixes from my node_modules fixed the problem for me. 😄 |
server.js if it existsserver.js if it has been regeneratedpi0
commented
Sep 1, 2021
Member
Thanks for PR @farnabaz. I've tried to use a different fix for this issue in #459 since we also have other race-conditions for moving during rebuilds. Reason of this move was supporting |
MemberAuthor
Oh, Indeed using CJS wrapper seems better solution. |
pi0
commented
Sep 5, 2021
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In some situations Nuxt Does not regenerate
server.jsand it cause file not found exception.This PR ensures
server.jsexistence before moving it toserver.cjs