Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs(typescript): typos - #4660

Merged
pi0 merged 5 commits into
mainfrom
docs/ts
Apr 27, 2022
Merged

docs(typescript): typos#4660
pi0 merged 5 commits into
mainfrom
docs/ts

Conversation

@atinux

@atinuxatinux commented Apr 27, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Explaining how to activate stricter types should be more visible.

@netlify

netlifyBot commented Apr 27, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit6810a78
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62691c2f2cbb3400097747bc
😎 Deploy Previewhttps://deploy-preview-4660--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0

pi0 commented Apr 27, 2022

Copy link
Copy Markdown
Member

We could highlight and explain strict option better but I think the main tsconfig is a much more generic concept to remain above and explain as is an essential part of every nuxt project.

DamianGlowala
DamianGlowala suggested changes Apr 27, 2022
View reviewed changes
Comment threaddocs/content/2.guide/1.concepts/6.typescript.md Outdated
Comment threaddocs/content/2.guide/1.concepts/6.typescript.md Outdated
Comment threaddocs/content/2.guide/1.concepts/6.typescript.md Outdated
Sébastien Chopinand others added 4 commits April 27, 2022 12:33
Sébastien Chopin@DamianGlowala
Update docs/content/2.guide/1.concepts/6.typescript.md
9b79fe7
Co-authored-by: Damian <48835293+DamianGlowala@users.noreply.github.com>
Sébastien Chopin@DamianGlowala
Update docs/content/2.guide/1.concepts/6.typescript.md
e60393b
Co-authored-by: Damian <48835293+DamianGlowala@users.noreply.github.com>
Sébastien Chopin@DamianGlowala
Update docs/content/2.guide/1.concepts/6.typescript.md
57d7003
Co-authored-by: Damian <48835293+DamianGlowala@users.noreply.github.com>
Sébastien Chopin
Update 6.typescript.md
6810a78
@atinuxatinux changed the title docs: move strict check abovedocs(typescript): typosApr 27, 2022
@atinux
atinux requested review from danielroe and pi0April 27, 2022 10:35
@pi0
pi0 merged commit 96b408a into mainApr 27, 2022
@pi0
pi0 deleted the docs/ts branch April 27, 2022 10:36
@pi0

pi0 commented Apr 27, 2022

Copy link
Copy Markdown
Member

Thanks ❤️

@pi0pi0 mentioned this pull request May 2, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pi0pi0Awaiting requested review from pi0
@danielroedanielroeAwaiting requested review from danielroe
1 more reviewer
@DamianGlowalaDamianGlowalaDamianGlowala requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atinux@pi0@DamianGlowala@danielroe