Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): await asyncData if ssr: false - #4791
Merged
Merged
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
commented
May 6, 2022
Member
I was thinking if we could make fix more generic and try to refetch if for any reason key is not in the payload (it can be |
MemberAuthor
Those are both nice ideas, but we wouldn't want to await on fetch in those cases as it would cause a hydration mismatch. (I think the solution to this bug and those is not connected.) Can we make that another issue and resolve in future PR? (happy to look at it straight away) |
pi0
approved these changes
May 6, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolvesnuxt/nuxt#13917
❓ Type of change
📚 Description
We should await
useAsyncDataon initial load if there was no SSR.📝 Checklist