Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt) : add default value for nitro.rollupConfig.plugins - #4830

Merged
pi0 merged 1 commit into
nuxt:mainfrom
huang-julien:fix/undefined-rollup-config
May 6, 2022
Merged

fix(nuxt) : add default value for nitro.rollupConfig.plugins#4830
pi0 merged 1 commit into
nuxt:mainfrom
huang-julien:fix/undefined-rollup-config

Conversation

@huang-julien

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvenuxt/nuxt#13927

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

rollup config is undefined and the import plugin registration is trying to push the plugin into an empty array here.
fixed by setting

 rollupConfig: {plugins: []}

into nitroConfig at package/nuxt/core/nitro.ts

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented May 5, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit0797d7a
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62745bc00522840008f7a595

@pi0pi0 changed the title fix(nuxt) : fix call on undefined array when buildingfix(nuxt) : add default value for nitro.rollupConfig.pluginsMay 6, 2022
pi0
pi0 approved these changes May 6, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@pi0
pi0 merged commit 6b16711 into nuxt:mainMay 6, 2022
@pi0pi0 mentioned this pull request May 6, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trying to push the ImportProtectionPlugin into an undefined array

3 participants

@huang-julien@pi0@danielroe