Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): clear errors after navigation - #4839

Merged
pi0 merged 2 commits into
mainfrom
fix/error-404
May 6, 2022
Merged

fix(nuxt): clear errors after navigation#4839
pi0 merged 2 commits into
mainfrom
fix/error-404

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

extracted fixes from #4539

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR fixes an issue where users who manually throw 404s can't escape from the error page (by clearing error after navigating to new route)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels May 6, 2022
@danielroe
danielroe requested a review from pi0May 6, 2022 09:32
@danielroedanielroe self-assigned this May 6, 2022
@netlify

netlifyBot commented May 6, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit58a94b1
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6274f60ec25ca8000840f0ea

Comment threadpackages/nuxt/src/pages/runtime/router.ts Outdated
pi0
pi0 approved these changes May 6, 2022
@pi0
pi0 merged commit 27d6736 into mainMay 6, 2022
@pi0
pi0 deleted the fix/error-404 branch May 6, 2022 10:50
@pi0pi0 mentioned this pull request May 6, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0