Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): check if default slot is provided before calling it - #4842

Merged
pi0 merged 1 commit into
mainfrom
fix/default-slots
May 6, 2022
Merged

fix(nuxt): check if default slot is provided before calling it#4842
pi0 merged 1 commit into
mainfrom
fix/default-slots

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#13935

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We should generally check if default slot is provided before calling it. This applies it across several different situations throughout the Nuxt app.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented May 6, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit6a01bc4
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6274f6ad8833ed0008b1e942

@danielroedanielroe self-assigned this May 6, 2022
@danielroe
danielroe requested a review from pi0May 6, 2022 10:21
@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels May 6, 2022
pi0
pi0 approved these changes May 6, 2022
@pi0
pi0 merged commit 7504606 into mainMay 6, 2022
@pi0
pi0 deleted the fix/default-slots branch May 6, 2022 10:52
@pi0pi0 mentioned this pull request May 6, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty NuxtLink component with target="_blank" - Error 500 - slots.default is not a function

2 participants

@danielroe@pi0