Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): use buildAssetsURL for dynamic imports - #4844

Merged
pi0 merged 1 commit into
mainfrom
fix/build-assets
May 6, 2022
Merged

fix(vite): use buildAssetsURL for dynamic imports#4844
pi0 merged 1 commit into
mainfrom
fix/build-assets

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#13637, resolvesnuxt/nuxt#13841

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We were wrongly using directory (/_nuxt) and not URL which adds it to the baseURL/cdnURL.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels May 6, 2022
@danielroe
danielroe requested a review from pi0May 6, 2022 10:42
@danielroedanielroe self-assigned this May 6, 2022
@netlify

netlifyBot commented May 6, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit383cf61
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6274fbaa502669000874b55d

pi0
pi0 approved these changes May 6, 2022
@pi0
pi0 merged commit 4079882 into mainMay 6, 2022
@pi0
pi0 deleted the fix/build-assets branch May 6, 2022 10:51
@pi0pi0 mentioned this pull request May 6, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working❗ p4-importantPriority 4: bugs that violate documented behavior, or significantly impact perfvite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JS assets are pulling twice when use app.cdnURL assets loaded with different URLs with custom baseURL

2 participants

@danielroe@pi0