Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxi): only reload for top level dirs - #4912

Merged
pi0 merged 1 commit into
mainfrom
fix/resolve-reload-dirs
May 13, 2022
Merged

fix(nuxi): only reload for top level dirs#4912
pi0 merged 1 commit into
mainfrom
fix/resolve-reload-dirs

Conversation

@danielroe

@danielroedanielroe commented May 10, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#13946

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

At the moment the creation of any pages, composables or components directory will trigger a reload, even deeply nested.

This PR resolves them to ensure we're not needlessly reloading nuxt.

📝 Checklist

  • I have linked an issue or discussion.
  • test on windows
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working cli 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels May 10, 2022
@danielroe
danielroe requested a review from pi0May 10, 2022 11:33
@danielroedanielroe self-assigned this May 10, 2022
@netlify

netlifyBot commented May 10, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitfdbdb17
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/627a4d8d54c2590008fae40b

pi0
pi0 approved these changes May 13, 2022
@pi0pi0 changed the title fix(nuxi): only reload for resolved resolved reload dirsfix(nuxi): only reload for top level dirsMay 13, 2022
@pi0
pi0 merged commit 2886dfd into mainMay 13, 2022
@pi0
pi0 deleted the fix/resolve-reload-dirs branch May 13, 2022 10:59
@pi0pi0 mentioned this pull request Jun 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't workingcli🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a pages directory from a module in a subdirectory makes vite compilation restart

2 participants

@danielroe@pi0