Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): check for 404s after user middleware - #4913

Merged
pi0 merged 1 commit into
mainfrom
fix/404-middleware
May 12, 2022
Merged

fix(nuxt): check for 404s after user middleware#4913
pi0 merged 1 commit into
mainfrom
fix/404-middleware

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#13931

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR moves 404 handling to after user middleware runs, meaning the user has a chance to redirect or handle it in other ways.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working pages 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels May 10, 2022
@danielroe
danielroe requested a review from pi0May 10, 2022 11:46
@danielroedanielroe self-assigned this May 10, 2022
@netlify

netlifyBot commented May 10, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit63e6130
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/627a5091d3e742000891221b

@pi0
pi0 merged commit 46c656c into mainMay 12, 2022
@pi0
pi0 deleted the fix/404-middleware branch May 12, 2022 09:13
@pi0pi0 mentioned this pull request Jun 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagepages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Middleware redirection failed. Expected '/ zh CN', actual '/' and page not found

2 participants

@danielroe@pi0