Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): respect baseurl when redirecting (and universal router) - #4933

Merged
pi0 merged 2 commits into
mainfrom
fix/redirect-baseurl
May 11, 2022
Merged

fix(nuxt): respect baseurl when redirecting (and universal router)#4933
pi0 merged 2 commits into
mainfrom
fix/redirect-baseurl

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#13974

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR:

  • uses baseURL when pushing with universal router (fixing an unreported error)
  • uses baseURL when sending a redirect

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels May 11, 2022
@danielroe
danielroe requested a review from pi0May 11, 2022 12:18
@danielroedanielroe self-assigned this May 11, 2022
@netlify

netlifyBot commented May 11, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitabafc75
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/627bacfccfc37100090dacbc

pi0
pi0 approved these changes May 11, 2022
@pi0
pi0 merged commit cad4edd into mainMay 11, 2022
@pi0
pi0 deleted the fix/redirect-baseurl branch May 11, 2022 17:33
@pi0pi0 mentioned this pull request Jun 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

navigateTo doesn't respect baseUrl.

2 participants

@danielroe@pi0