Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
feat(vite): replace global with globalThis - #4958
Merged
Merged
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
global with globalThispi0
commented
May 13, 2022
Member
Is it relevant to app build? |
pi0
approved these changes
May 13, 2022
pi0
left a comment
Member
There was a problem hiding this comment.
Looks good to me we can try on edge :)
danielroe
marked this pull request as ready for review
May 13, 2022 10:40
danielroe added a commit
that referenced
this pull request
May 13, 2022
18 tasks
Merged
70 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
nuxt/nuxt#12830, closesnuxt/nuxt#13941
❓ Type of change
📚 Description
This PR replaces references to
globalwithglobalThisfor ESM compatibility, following the implementation in Nitro (e.g. nitrojs/nitro#155 - which makes it safer to do this).This is currently a draft pending more testing (e.g. for AWS Amplify).
📝 Checklist