Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs(api): improve useFetch docs for body type and additional ohmyfetch options - #4985

Merged
pi0 merged 4 commits into
nuxt:mainfrom
ArthurMJ96:docs-api-useFetch
May 20, 2022
Merged

docs(api): improve useFetch docs for body type and additional ohmyfetch options#4985
pi0 merged 4 commits into
nuxt:mainfrom
ArthurMJ96:docs-api-useFetch

Conversation

@ArthurMJ96

@ArthurMJ96ArthurMJ96 commented May 14, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added useFetch API documentation for Request body option.
Changed useFetch Params documentation for Options to mention which types it extends.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented May 14, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit859b4d5
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6285403001436600089fc58e

@ArthurMJ96ArthurMJ96 changed the title Docs api use fetchdocs: add useFetch API documentation for Request body & extended types.May 14, 2022
@danielroedanielroe added the documentation Improvements or additions to documentation label May 16, 2022
atinux
atinux approved these changes May 18, 2022
View reviewed changes

@atinuxatinux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only thing is that we shall avoid linking to source code since it can change with time.

pi0
pi0 reviewed May 20, 2022
View reviewed changes
Comment threaddocs/content/3.api/1.composables/use-fetch.md Outdated
@pi0pi0 changed the title docs: add useFetch API documentation for Request body & extended types.docs(api): improve useFetch docs for body type and additional ohmyfetch optionsMay 20, 2022
pi0
pi0 approved these changes May 20, 2022
View reviewed changes

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0
pi0 merged commit 2a43cb4 into nuxt:mainMay 20, 2022
@ArthurMJ96
ArthurMJ96 deleted the docs-api-useFetch branch May 20, 2022 19:58
@pi0pi0 mentioned this pull request Jun 10, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@atinuxatinuxatinux approved these changes
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.xdocumentationImprovements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArthurMJ96@atinux@pi0@danielroe