Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(test-utils): hardcode ipv4 ip for localhost - #4998

Merged
antfu merged 1 commit into
mainfrom
fix/test-localhost
May 17, 2022
Merged

fix(test-utils): hardcode ipv4 ip for localhost#4998
antfu merged 1 commit into
mainfrom
fix/test-localhost

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#13964

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Seems we have an issue with ipv6 in testing that we can avoid by hard-coding to ipv4.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
danielroe requested a review from antfuMay 16, 2022 10:40
@danielroedanielroe self-assigned this May 16, 2022
@netlify

netlifyBot commented May 16, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit4f805ea
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62822a2e53eac50009bb7df9

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage test-utils labels May 16, 2022
@antfu
antfu merged commit cd37a21 into mainMay 17, 2022
@antfu
antfu deleted the fix/test-localhost branch May 17, 2022 01:40
@pi0pi0 mentioned this pull request Jun 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagetest-utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ipv4 / ipv6 - Problem when using $fetch() while testing with vitest

2 participants

@danielroe@antfu