Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): transform extends layers within node_modules - #5042

Merged
pi0 merged 11 commits into
mainfrom
fix/transpile-extends
Jun 10, 2022
Merged

fix(nuxt): transform extends layers within node_modules#5042
pi0 merged 11 commits into
mainfrom
fix/transpile-extends

Conversation

@danielroe

@danielroedanielroe commented May 18, 2022•
edited
Loading

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#13996

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds support for auto-imports within extends layers, as well as adding them to build.transpile. Incidentally, it also fixes a nasty bug with webpack where we weren't respecting build.transpile (I may extract the latter to a separate PR if this PR needs more attention).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels May 18, 2022
@danielroe
danielroe requested a review from pi0May 18, 2022 15:02
@danielroedanielroe self-assigned this May 18, 2022
@netlify

netlifyBot commented May 18, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit5f7ddd2
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62a344b82592f00009b2aa0b

@danielroedanielroe mentioned this pull request May 18, 2022
Merged
7 tasks
pi0
pi0 reviewed May 20, 2022
View reviewed changes
Comment threadpackages/webpack/src/presets/nuxt.ts Outdated
Comment threadpackages/nuxt/src/core/nuxt.ts Outdated
Comment threadpackages/nuxt/src/auto-imports/module.ts Outdated
pi0
pi0 reviewed Jun 10, 2022
View reviewed changes
Comment threadpackages/nuxt/src/core/nuxt.ts Outdated
@pi0pi0 changed the title feat(nuxt): support auto imports within layers in node_modulesfix(nuxt): support auto imports within extend layers in node_modulesJun 10, 2022
@pi0pi0 changed the title fix(nuxt): support auto imports within extend layers in node_modulesfix(nuxt): transform extends layers within node_modulesJun 10, 2022
@pi0

pi0 commented Jun 10, 2022

Copy link
Copy Markdown
Member

@danielroe Can you please check if we also need this for nitro options to include layers?

pi0
pi0 approved these changes Jun 10, 2022
View reviewed changes
@pi0
pi0 merged commit 846be5c into mainJun 10, 2022
@pi0
pi0 deleted the fix/transpile-extends branch June 10, 2022 13:33
This was referenced Jun 10, 2022
Merged
Merged
This was referenced Jun 12, 2022
Merged
Open
@john-eosjohn-eos mentioned this pull request Mar 20, 2023
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xenhancementNew feature or request🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support auto-imports when using extends

2 participants

@danielroe@pi0