Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): allow passing extraneous attrs to meta components - #5071

Merged
pi0 merged 1 commit into
mainfrom
fix/extra-attrs
May 20, 2022
Merged

fix(nuxt): allow passing extraneous attrs to meta components#5071
pi0 merged 1 commit into
mainfrom
fix/extra-attrs

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#13894

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

A straightforward fix - attrs aren't meant to be passed on for these meta components.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels May 19, 2022
@danielroe
danielroe requested a review from pi0May 19, 2022 20:43
@danielroedanielroe self-assigned this May 19, 2022
@netlify

netlifyBot commented May 19, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit1f204b2
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6286ac0d5ce5e800081ba83c
😎 Deploy Previewhttps://deploy-preview-5071--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pi0
pi0 approved these changes May 20, 2022
@pi0
pi0 merged commit a4a3cff into mainMay 20, 2022
@pi0
pi0 deleted the fix/extra-attrs branch May 20, 2022 14:42
@pi0pi0 mentioned this pull request Jun 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

custom attrs in <Html> component

2 participants

@danielroe@pi0