Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs: add documentation for titleTemplate - #5093

Merged
pi0 merged 4 commits into
nuxt:mainfrom
entity:update-documentation-for-titletemplate
Jun 3, 2022
Merged

docs: add documentation for titleTemplate#5093
pi0 merged 4 commits into
nuxt:mainfrom
entity:update-documentation-for-titletemplate

Conversation

@entity

Copy link
Copy Markdown
Contributor

🔗 Linked issue

nuxt/nuxt#13981 (And #5057 for PR)

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This change adds more clarity to the titleTemplate option, as currently in Nuxt 3 this doesn't work as intended. This resolvesnuxt/nuxt#13981. This is a re-added PR to #5057, accidentally deleted the repo when adding multiple PRs to Nuxt.

Some changes were resolved by @manniL, @danielroe and @DamianGlowala.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented May 21, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit4626e89
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/629a1e85a4a52c0008d5818d
😎 Deploy Previewhttps://deploy-preview-5093--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe
danielroe self-requested a review May 21, 2022 10:08
@atinux

Copy link
Copy Markdown
Member

Thanks @heychazza

I would suggest to document it to be used in app.vue instead of creating a plugin for it. Otherwise changes look good to me!

@danielroe

Copy link
Copy Markdown
Member

Yes, please see my suggested changes on the previous PR.

@entity

Copy link
Copy Markdown
ContributorAuthor

Thanks @heychazza

I would suggest to document it to be used in app.vue instead of creating a plugin for it. Otherwise changes look good to me!

Thank you lots! Daniel did mention this but I completely overlooked it.

Will add those changes tomorrow once I'm at the computer.

pi0
pi0 approved these changes Jun 3, 2022
@pi0
pi0 merged commit e6b48c2 into nuxt:mainJun 3, 2022
@entity
entity deleted the update-documentation-for-titletemplate branch June 3, 2022 15:50
@pi0pi0 mentioned this pull request Jun 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot set titleTemplate as function

4 participants

@entity@atinux@danielroe@pi0