Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs: fix nuxt app guide linking to a 404 page - #5122

Merged
pi0 merged 2 commits into
nuxt:mainfrom
entity:update-nuxt-app-documentation
May 24, 2022
Merged

docs: fix nuxt app guide linking to a 404 page#5122
pi0 merged 2 commits into
nuxt:mainfrom
entity:update-nuxt-app-documentation

Conversation

@entity

@entityentity commented May 24, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

N/A

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Updates the nuxt app docs as the link went to a 404, on closer look it seems this isn't being caught by

/docs/directory-structure/*/guide/directory-structure/:splat302!

Update: Seems navigating through the app itself gives a 404, but going directly to the link redirects me.

Reproduction

  1. Go to https://v3.nuxtjs.org/guide/going-further/nuxt-app/
  2. Click Read more about plugins.
  3. It 404's.
  4. If you refresh the page at the 404, it'll redirect you.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented May 24, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitf78a2b2
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/628ca985dafdf2000851bd7f
😎 Deploy Previewhttps://deploy-preview-5122--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@entity

Copy link
Copy Markdown
ContributorAuthor

On further inspection, it seems like Netlifys redirection rules don't apply within the docs itself. I'm unsure if the docs are an SPA or something alike, where Netlify would never see the page load (after first loading).

See:
CleanShot 2022-05-24 at 10 53 15

@pi0

pi0 commented May 24, 2022

Copy link
Copy Markdown
Member

On further inspection, it seems like Netlifys redirection rules don't apply within the docs itself. I'm unsure if the docs are an SPA or something alike, where Netlify would never see the page load (after first loading).

We always had this issue but will hopefully be solved once we had routes rules that can generate universal redirection rules (both netlify-native and app universal)

@pi0

pi0 commented May 24, 2022

Copy link
Copy Markdown
Member

Thanks!

@pi0
pi0 merged commit 32cb06b into nuxt:mainMay 24, 2022
@entity

Copy link
Copy Markdown
ContributorAuthor

On further inspection, it seems like Netlifys redirection rules don't apply within the docs itself. I'm unsure if the docs are an SPA or something alike, where Netlify would never see the page load (after first loading).

We always had this issue but will hopefully be solved once we had routes rules that can generate universal redirection rules (both netlify-native and app universal)

Ah I see! That makes sense, the fun of super strange bugs haha

@entity
entity deleted the update-nuxt-app-documentation branch May 24, 2022 14:16
@pi0pi0 mentioned this pull request Jun 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@entity@pi0@danielroe