Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): respect navigateTo options using server middleware in server-side - #5145

Merged
pi0 merged 2 commits into
mainfrom
fix/navigate-middleware-server
May 31, 2022
Merged

fix(nuxt): respect navigateTo options using server middleware in server-side#5145
pi0 merged 2 commits into
mainfrom
fix/navigate-middleware-server

Conversation

@danielroe

@danielroedanielroe commented May 25, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/nuxt#13993

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

On SSR we can directly redirect within middleware when user calls navigateTo, which will also mean we can respect the user's options.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels May 25, 2022
@danielroe
danielroe requested a review from pi0May 25, 2022 15:15
@danielroedanielroe self-assigned this May 25, 2022
@netlify

netlifyBot commented May 25, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit3ac3e6b
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/629691727fc8bb0008218e5d
😎 Deploy Previewhttps://deploy-preview-5145--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pi0
pi0 reviewed May 31, 2022
View reviewed changes
Comment threadpackages/nuxt/src/app/composables/router.ts
@danielroe@pi0
docs: add comment
3ac3e6b
Co-authored-by: pooya parsa <pyapar@gmail.com>
@pi0pi0 changed the title fix(nuxt): respect navigateTo options on SSR mwfix(nuxt): respect navigateTo options using server middleware in server-sideMay 31, 2022
pi0
pi0 approved these changes May 31, 2022
View reviewed changes
@pi0
pi0 merged commit 1fda732 into mainMay 31, 2022
@pi0
pi0 deleted the fix/navigate-middleware-server branch May 31, 2022 22:09
@pi0pi0 mentioned this pull request Jun 10, 2022
Merged
@danielroedanielroe mentioned this pull request Sep 7, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0