Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(schema): add missed types title, bodyAttrs, htmlAttrs - #5184

Merged
pi0 merged 4 commits into
nuxt:mainfrom
cawa-93:patch-1
May 31, 2022
Merged

fix(schema): add missed types title, bodyAttrs, htmlAttrs#5184
pi0 merged 4 commits into
nuxt:mainfrom
cawa-93:patch-1

Conversation

@cawa-93

@cawa-93cawa-93 commented May 28, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

In fact, these properties already work but were not in the type declarations

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented May 28, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit9a33cc7
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62935bd5ff375d00094e63f2
😎 Deploy Previewhttps://deploy-preview-5184--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cawa-93cawa-93 changed the title fix: add missed types title, bodyAttr, htmlAttr to schemafix: add missed types title, bodyAttrs, htmlAttrs to schemaMay 28, 2022
danielroe
danielroe reviewed May 29, 2022
View reviewed changes
Comment threadpackages/schema/src/types/meta.ts Outdated
@danielroedanielroe changed the title fix: add missed types title, bodyAttrs, htmlAttrs to schemafix(schema): add missed types title, bodyAttrs, htmlAttrs to schemaMay 29, 2022
@danielroedanielroe changed the title fix(schema): add missed types title, bodyAttrs, htmlAttrs to schemafix(schema): add missed types title, bodyAttrs, htmlAttrsMay 29, 2022
danielroe
danielroe reviewed May 29, 2022
View reviewed changes
Comment threadpackages/schema/src/types/meta.ts Outdated
@pi0
pi0 merged commit 1e8fba8 into nuxt:mainMay 31, 2022
@pi0

pi0 commented May 31, 2022

Copy link
Copy Markdown
Member

Thanks!

@pi0pi0 mentioned this pull request Jun 10, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@danielroedanielroedanielroe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cawa-93@pi0@danielroe