Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

refactor(vite, webpack, test-utils): use caret range for vue peer dependency - #5190

Merged
pi0 merged 1 commit into
mainfrom
chore/vue-peer-dep
May 31, 2022
Merged

refactor(vite, webpack, test-utils): use caret range for vue peer dependency#5190
pi0 merged 1 commit into
mainfrom
chore/vue-peer-dep

Conversation

@danielroe

@danielroedanielroe commented May 29, 2022

Copy link
Copy Markdown
Member

❓ Type of change

  • 🧹 Chore

📚 Description

Currently we pin our peer-dep on vue to a specific version, but we use a range for the nuxt vue dependency. That will lead to a failing pnpm install (among other issues):

+ nuxt 3.0.0-rc.3
ERR_PNPM_PEER_DEP_ISSUES Unmet peer dependencies
.
└─┬ nuxt
└─┬ @nuxt/vite-builder
└── ✕ unmet peer vue@3.2.33: found 3.2.36 in nuxt

resolvesnuxt/nuxt#14029

@danielroedanielroe added chore 🧹 p1-chore Priority 1: no change in change code behavior labels May 29, 2022
@danielroe
danielroe requested a review from pi0May 29, 2022 11:36
@danielroedanielroe self-assigned this May 29, 2022
@netlify

netlifyBot commented May 29, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit5e38a8d
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62935ab6320aa8000a56c1e8

@pi0pi0 changed the title chore: use range for vue peer-deprefactor: use range for vue peer-depMay 31, 2022
@pi0pi0 changed the title refactor: use range for vue peer-deprefactor: use caret range for vue peer dependencyMay 31, 2022
@pi0pi0 changed the title refactor: use caret range for vue peer dependencyrefactor(vite, webpack, test-utils): use caret range for vue peer dependencyMay 31, 2022
@pi0
pi0 merged commit baf2baa into mainMay 31, 2022
@pi0
pi0 deleted the chore/vue-peer-dep branch May 31, 2022 22:36
@pi0pi0 mentioned this pull request Jun 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xchore🧹 p1-chorePriority 1: no change in change code behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install fails with pnpm

2 participants

@danielroe@pi0