Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs(examples): rename hello.ts to [...hello].ts - #5261

Merged
pi0 merged 4 commits into
nuxt:mainfrom
qin-guan:patch-1
Jun 22, 2022
Merged

docs(examples): rename hello.ts to [...hello].ts#5261
pi0 merged 4 commits into
nuxt:mainfrom
qin-guan:patch-1

Conversation

@qin-guan

Copy link
Copy Markdown
Contributor

🔗 Linked issue

nuxt/nuxt#14077

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Fixes a bad server route in useFetch example

Resolvesnuxt/nuxt#14077

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Jun 2, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commite273b38
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62b3506d258ecd0008468223

@danielroedanielroe changed the title fix(examples): rename hello.ts to [...hello].tsdocs(examples): rename hello.ts to [...hello].tsJun 3, 2022
@pi0

pi0 commented Jun 3, 2022

Copy link
Copy Markdown
Member

Thanks for this PR @qin-guan 💚 It seems working an good fix. Since we are now using named route params, we can also replace parseURL().pathname (here) to event.context.params.id.

@qin-guan

Copy link
Copy Markdown
ContributorAuthor

I see, thanks for the feedback! I will update the PR :)

@qin-guan

Copy link
Copy Markdown
ContributorAuthor

Hey @pi0, sorry for the late update, 😔 PTAL

Comment threadexamples/composables/use-fetch/server/api/[...hello].ts Outdated
pi0
pi0 approved these changes Jun 22, 2022
@pi0
pi0 merged commit 2156079 into nuxt:mainJun 22, 2022
@pi0

pi0 commented Jun 22, 2022

Copy link
Copy Markdown
Member

Thanks for working on this!

@qin-guan

Copy link
Copy Markdown
ContributorAuthor

Thanks for this first PR opportunity, and for all the work y'all are doing with Nuxt, truly amazing! 🙌🏻 🙏🏻

@pi0pi0 mentioned this pull request Jul 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useFetch example in documentation is broken

3 participants

@qin-guan@pi0@danielroe