Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): support RouterView props in NuxtPage - #5272

Merged
pi0 merged 1 commit into
mainfrom
fix/router-view-compat
Jun 3, 2022
Merged

fix(nuxt): support RouterView props in NuxtPage#5272
pi0 merged 1 commit into
mainfrom
fix/router-view-compat

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14095

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds support to NuxtPage for features present in RouterView:

It also allows RouterView to handle attrs for consistency.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Jun 3, 2022
@danielroe
danielroe requested a review from pi0June 3, 2022 09:17
@danielroedanielroe self-assigned this Jun 3, 2022
@netlify

netlifyBot commented Jun 3, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitbe5f364
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6299d1b0ebd179000801f8c7

pi0
pi0 approved these changes Jun 3, 2022
@pi0pi0 changed the title fix(nuxt): support RouterView props in NuxtPagefix(nuxt): support RouterView props in NuxtPageJun 3, 2022
@pi0
pi0 merged commit eb12c7a into mainJun 3, 2022
@pi0
pi0 deleted the fix/router-view-compat branch June 3, 2022 14:01
@pi0pi0 mentioned this pull request Jun 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NuxtPage typing doesn't allow passing custom props.

2 participants

@danielroe@pi0