Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): add ssrContext types on NuxtApp - #5333

Merged
pi0 merged 3 commits into
mainfrom
fix/ssrcontext-types
Jun 8, 2022
Merged

fix(nuxt): add ssrContext types on NuxtApp#5333
pi0 merged 3 commits into
mainfrom
fix/ssrcontext-types

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14102

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds types to ssrContext (with req/res deprecated).

Relevant code changes: it also removes redirected (Nuxt 2, not otherwise used in Nuxt 3 codebase) and doesn't pass an empty object to initialise server entry.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working types labels Jun 7, 2022
@danielroe
danielroe requested a review from pi0June 7, 2022 13:47
@danielroedanielroe self-assigned this Jun 7, 2022
@netlify

netlifyBot commented Jun 7, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit0b5efc6
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/629f74c52bab490008be0e1b

pi0
pi0 approved these changes Jun 8, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pi0
pi0 merged commit 822928b into mainJun 8, 2022
@pi0
pi0 deleted the fix/ssrcontext-types branch June 8, 2022 19:37
@pi0pi0 mentioned this pull request Jun 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't workingtypes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No types for nuxtApp.ssrContext

3 participants

@danielroe@pi0@luisoos