Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(types): tidy types for useAsyncData - #5340

Merged
pi0 merged 2 commits into
mainfrom
fix/type-pick-from
Jun 8, 2022
Merged

fix(types): tidy types for useAsyncData#5340
pi0 merged 2 commits into
mainfrom
fix/type-pick-from

Conversation

@antfu

@antfuantfu commented Jun 7, 2022

Copy link
Copy Markdown
Member

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Use Pick<T, K> only when necessary to make the type cleaner

Before

image

Or

image

After

image

image

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Jun 7, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitf4ce2ae
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62a06f1d1ee80b00086d8354

@antfu
antfu requested a review from danielroeJune 7, 2022 23:03
danielroe
danielroe reviewed Jun 8, 2022
View reviewed changes
Comment threadpackages/nuxt/src/app/composables/asyncData.ts Outdated
danielroe
danielroe approved these changes Jun 8, 2022
View reviewed changes

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👌

pi0
pi0 approved these changes Jun 8, 2022
View reviewed changes

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@pi0
pi0 merged commit eafd92c into mainJun 8, 2022
@pi0
pi0 deleted the fix/type-pick-from branch June 8, 2022 19:45
@pi0pi0 mentioned this pull request Jun 10, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@pi0pi0pi0 approved these changes
@danielroedanielroedanielroe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antfu@pi0@danielroe