Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): relax server import protections - #5355

Merged
pi0 merged 3 commits into
mainfrom
fix/unprotect-utils
Jun 8, 2022
Merged

fix(nuxt): relax server import protections#5355
pi0 merged 3 commits into
mainfrom
fix/unprotect-utils

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14118

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This removes import protection outside of ~/server/api/ and ~/server/middleware/ directories, for shared utilities.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Jun 8, 2022
@danielroe
danielroe requested a review from pi0June 8, 2022 14:06
@danielroedanielroe self-assigned this Jun 8, 2022
@netlify

netlifyBot commented Jun 8, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit9fcdbc6
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62a0fdb7a987a800095073d6
😎 Deploy Previewhttps://deploy-preview-5355--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Comment threadpackages/nuxt/src/core/plugins/import-protection.ts Outdated
@pi0pi0 changed the title fix(nuxt): remove server import protection outside of api/middlewarefix(nuxt): relax server import protectionsJun 8, 2022
Comment threadpackages/nuxt/src/core/plugins/import-protection.ts Outdated
@pi0
pi0 merged commit 247deac into mainJun 8, 2022
@pi0
pi0 deleted the fix/unprotect-utils branch June 8, 2022 19:51
@pi0pi0 mentioned this pull request Jun 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow importing from generic ~/server/utils

2 participants

@danielroe@pi0