Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(webpack): write stub server file with ssr: false - #5372
Closed
danielroe wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
bachilli
approved these changes
Jun 9, 2022
florian-lefebvre
commented
Jun 9, 2022
Contributor
What about vite? |
danielroe
commented
Jun 9, 2022
MemberAuthor
@florian-lefebvre Are you experiencing an issue with vite? Do you have a link to an issue? |
florian-lefebvre
commented
Jun 9, 2022
Contributor
Yes, looks like nuxt/nuxt#14114 is the same for vite |
pi0
commented
Jun 10, 2022
Member
I think have a better universal solution for this using nitro. That's why put pending :) |
7 tasks
pi0
commented
Jul 7, 2022
Member
Moving to #5773 using virtual imports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolvesnuxt/nuxt#13986
❓ Type of change
📚 Description
Rollup needs to resolve
#build/dist/server/server.mjseven though it will never be used/imported (src). This PR ensures the stub is present in webpack, just as it is in vite.📝 Checklist