Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(kit): pass resolved path to isIgnored - #5375

Merged
pi0 merged 1 commit into
mainfrom
fix/ignore-subdirs
Jun 10, 2022
Merged

fix(kit): pass resolved path to isIgnored#5375
pi0 merged 1 commit into
mainfrom
fix/ignore-subdirs

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14129

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We were not passing the full path to the isIgnored test so weren't properly ignoring files.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jun 9, 2022
@danielroe
danielroe requested a review from pi0June 9, 2022 15:19
@danielroedanielroe self-assigned this Jun 9, 2022
@netlify

netlifyBot commented Jun 9, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit254b410
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62a20f937b2d3b0009ea7410
😎 Deploy Previewhttps://deploy-preview-5375--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0pi0 mentioned this pull request Jun 10, 2022
@pi0
pi0 merged commit 6947d30 into mainJun 10, 2022
@pi0
pi0 deleted the fix/ignore-subdirs branch June 10, 2022 12:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ignore pages not work

2 participants

@danielroe@pi0