Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(vite)!: upgrade vite to v3 - #5398

Merged
pi0 merged 58 commits into
mainfrom
chore/vite-3
Jul 21, 2022
Merged

feat(vite)!: upgrade vite to v3#5398
pi0 merged 58 commits into
mainfrom
chore/vite-3

Conversation

@danielroe

@danielroedanielroe commented Jun 10, 2022

Copy link
Copy Markdown
Member

📚 Description

This PR upgrades Vite to v3 beta.

There are a couple of fixes/refactors to note:

  1. We remove the workaround where we move build output files around, instead modifying chunk names (resolvesBuilding to .output is placing public files in 2 separate locations nuxt#12178).

  2. We remove our runtime URL implementation, using new Vite support from feat: experimental.buildAdvancedBaseOptions vitejs/vite#8450.

    We'll track the development of this feature quite closely as it moves from experimental into the mainstream, but it will not break in a minor version so the current version constraint is safe.

resolvesnuxt/nuxt#13780, resolvesnuxt/nuxt#14267, resolvesnuxt/nuxt#13953, resolvesnuxt/nuxt#13247, resolvesnuxt/nuxt#14341, resolvesnuxt/nuxt#14327, resolvesnuxt/nuxt#14354.

👉 Migration

Vite 3 is a major release with its own breaking changes. Users should read through the migration guide and make any updates necessary. (Other libraries may also have to be updated to work with Vite 3.)

There are no Nuxt-specific changes that users will need to make.

@danielroedanielroe self-assigned this Jun 10, 2022
@netlify

netlifyBot commented Jun 10, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitb832953
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62d929c43a09ac0008954999

@danielroedanielroe changed the title chore: upgrade vite to alphachore: upgrade vite to v3Jun 10, 2022
@danielroe
danielroeforce-pushed the chore/vite-3 branch 2 times, most recently from ffb68bf to bc7c929CompareJune 11, 2022 20:07
@danielroedanielroe changed the title chore: upgrade vite to v3feat!: upgrade vite to v3Jun 13, 2022
@danielroedanielroe changed the title feat!: upgrade vite to v3feat(vite)!: upgrade vite to v3Jun 13, 2022
@danielroe
danielroeforce-pushed the chore/vite-3 branch 2 times, most recently from f29a4f6 to 38826e3CompareJune 20, 2022 15:58
@patak-cat

Copy link
Copy Markdown

Linking to the externals regression PR (wip), 986264a could be reverted after we fix this

Comment threadpackages/vite/src/client.ts
@danielroedanielroe added enhancement New feature or request vite labels Jul 11, 2022
@danielroe
danielroe marked this pull request as ready for review July 12, 2022 08:50
@misaon

Copy link
Copy Markdown
Contributor

Waiting ❤️

pi0
pi0 approved these changes Jul 21, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Locally tried base url options too.

@tylerforesthauser

tylerforesthauser commented Jul 22, 2022

Copy link
Copy Markdown

Hey guys! I'm excited to get using Vite 3 but I've noticed that this PR actually seems to overwrite user Vite settings (as set in nuxt.config).

I think perhaps the configs are provided here in the reverse order...

Hopefully it's something just this simple 😅

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xenhancementNew feature or requestvite

Projects

None yet

6 participants

@danielroe@patak-cat@misaon@tylerforesthauser@pi0@JemiloII