Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): don't terminate with escaped delimiters - #5409

Merged
pi0 merged 1 commit into
mainfrom
fix/asset-strings
Jun 10, 2022
Merged

fix(vite): don't terminate with escaped delimiters#5409
pi0 merged 1 commit into
mainfrom
fix/asset-strings

Conversation

@danielroe

@danielroedanielroe commented Jun 10, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14097

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This resolves an issue where an escaped quotation was terminating a regexp wrongly.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Jun 10, 2022
@danielroe
danielroe requested a review from pi0June 10, 2022 15:12
@danielroedanielroe self-assigned this Jun 10, 2022
@netlify

netlifyBot commented Jun 10, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitcef4c0c
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62a35f5e1220300008de0c9f

pi0
pi0 approved these changes Jun 10, 2022
View reviewed changes
@pi0
pi0 merged commit 8831e4a into mainJun 10, 2022
@pi0
pi0 deleted the fix/asset-strings branch June 10, 2022 15:17
This was referenced Jun 10, 2022
Closed
Closed
@pi0pi0 mentioned this pull request Jun 12, 2022
Merged
@danielroedanielroe mentioned this pull request Jun 15, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working❗ p4-importantPriority 4: bugs that violate documented behavior, or significantly impact perfvite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failed to parse source for import analysis because the content contains invalid JS syntax

2 participants

@danielroe@pi0