Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

refactor(nuxi): improve env update message - #5430

Merged
pi0 merged 3 commits into
nuxt:mainfrom
ennioVisco:dx-env-override
Jun 12, 2022
Merged

refactor(nuxi): improve env update message#5430
pi0 merged 3 commits into
nuxt:mainfrom
ennioVisco:dx-env-override

Conversation

@ennioVisco

@ennioViscoennioVisco commented Jun 12, 2022

Copy link
Copy Markdown
Contributor

Updated the warning message to provide some insights to the developers about the fact that he did not do something wrong per se, but many libraries would not be behaving correctly.

🔗 Linked issue

Related to a9c061c#commitcomment-75926157 and nuxt/nuxt#14057.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@ennioVisco
Update env.ts
80d9254
Updated the warning message to provide some insights to the developers about the fact that he did not do something wrong per se, but many libraries would not be behaving correctly.
@netlify

netlifyBot commented Jun 12, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit90edc91
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62a6646719201b000950ed0c

pi0
pi0 reviewed Jun 12, 2022
View reviewed changes
Comment threadpackages/nuxi/src/utils/env.ts Outdated
@pi0pi0 changed the title Update env.tsrefactor(nuxi): improve env update messageJun 12, 2022
@pi0
pi0 requested a review from danielroeJune 12, 2022 22:02
danielroe
danielroe reviewed Jun 12, 2022
View reviewed changes
Comment threadpackages/nuxi/src/utils/env.ts Outdated
pi0
pi0 approved these changes Jun 12, 2022
View reviewed changes

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0
pi0 merged commit 9d28c0a into nuxt:mainJun 12, 2022
@pi0pi0 mentioned this pull request Jun 12, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@danielroedanielroedanielroe left review comments
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ennioVisco@pi0@danielroe