Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): normalize string transpile paths for windows - #5461

Merged
pi0 merged 2 commits into
mainfrom
fix/windows-transpiles
Jun 15, 2022
Merged

fix(nuxt): normalize string transpile paths for windows#5461
pi0 merged 2 commits into
mainfrom
fix/windows-transpiles

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14084

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This normalises any string transpiles added by modules/user (particularly relevant for Windows support).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jun 14, 2022
@danielroe
danielroe requested a review from pi0June 14, 2022 12:51
@danielroedanielroe self-assigned this Jun 14, 2022
@netlify

netlifyBot commented Jun 14, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commited7abca
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62a9c80384a9d60008456b78
😎 Deploy Previewhttps://deploy-preview-5461--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pi0
pi0 approved these changes Jun 15, 2022
Comment threadpackages/nuxt/src/core/nuxt.ts Outdated
@pi0
pi0 merged commit e10517d into mainJun 15, 2022
@pi0
pi0 deleted the fix/windows-transpiles branch June 15, 2022 11:52
@pi0

pi0 commented Jun 15, 2022

Copy link
Copy Markdown
Member

Note for the future: We might find a way that untyped schema normalization can handle the modifications. But probably longer term goal when we had proxy.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[windows] package import specifier "#imports" is not defined in package

3 participants

@danielroe@pi0@antfu