Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(kit): add addLayout - #5537

Merged
pi0 merged 6 commits into
mainfrom
fix/kit-add-layout
Jun 27, 2022
Merged

feat(kit): add addLayout#5537
pi0 merged 6 commits into
mainfrom
fix/kit-add-layout

Conversation

@danielroe

@danielroedanielroe commented Jun 20, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

resolvesnuxt/nuxt#14181

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds a Nuxt 3 implementation for this.addLayout and also exports it as a standalone util. Happy to go in the other direction and reconsider the standalone utility (or even deprecate the module container util), but if we have it, we might as well make it available and working on nuxt 3.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
danielroe requested a review from pi0June 20, 2022 15:48
@danielroedanielroe self-assigned this Jun 20, 2022
@netlify

netlifyBot commented Jun 20, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitc39dcc2
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62b3554be4f1d30009a10804
😎 Deploy Previewhttps://deploy-preview-5537--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0

pi0 commented Jun 20, 2022

Copy link
Copy Markdown
Member

I think this PR is introducing a new feature :)

Comment threadpackages/kit/src/layout.ts Outdated
Comment threadpackages/kit/src/layout.ts Outdated
Comment threadpackages/kit/src/layout.ts
@pi0pi0 changed the title fix(kit): add nuxt 3 implementation for addLayout and separate utilfeat(kit): add addLayoutJun 20, 2022
@danielroedanielroe added the enhancement New feature or request label Jun 21, 2022
Comment threadpackages/kit/src/layout.ts Outdated
Comment threadpackages/kit/src/layout.ts Outdated
Comment threadpackages/kit/src/layout.ts
pi0
pi0 approved these changes Jun 27, 2022
@pi0
pi0 merged commit 6f8b7a9 into mainJun 27, 2022
@pi0
pi0 deleted the fix/kit-add-layout branch June 27, 2022 11:47
@sppmstar

Copy link
Copy Markdown

when will this update be published ?

@atinux

Copy link
Copy Markdown
Member

You can already play with it using the edge channel @sppmstar : https://v3.nuxtjs.org/guide/going-further/edge-channel

@sppmstar

Copy link
Copy Markdown

@atinux I have a nuxt module generated by nuxi. I tried the edge channel approach documented in the link you shared with me, but when i run yarn why @nuxt/kit i still see rc4 version being installed, which does not include the addLayout helper i need :(

@atinux

Copy link
Copy Markdown
Member

Can you try with:

"@nuxt/kit": "npm:@nuxt/kit-edge@latest"

@sppmstar

Copy link
Copy Markdown

That worked! thanks a lot :)

@pi0pi0 mentioned this pull request Jul 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xenhancementNew feature or requestkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

moduleContainer addlayout not working

4 participants

@danielroe@pi0@sppmstar@atinux